fix: add impersonated SA via local ADC support for fetch_id_token #1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-sunder-s
reviewed
Apr 8, 2025
sai-sunder-s
approved these changes
Apr 9, 2025
nolanleastin
force-pushed
the
neastin/id-token-impersonated-sa
branch
2 times, most recently
from
95efd68 to
ce4845b
Compare
nolanleastin
force-pushed
the
neastin/id-token-impersonated-sa
branch
from
ce4845b to
13ffc87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch_id_token was only supported for service accounts and fetch ID token from metadata server if it exists.
This PR adds support for impersonated service accounts.